Re: CF: cone bug fix

[Nishita Seikoh <s-nisita@ics.es.osaka-u.ac.jp>]

Hi, everyone.
About two month ago I made two patches for ok_to_put_more() and
cast_cone() in spell_util.c,
and my patches seem to be adopted in v.0.94.1.
I guess the problem is caused by them.

> Well, in 0.94.1 it is impossible to kill monsters which are more than
> 1 field in size (wizards, jessies...) with face of death, since the
> spell just goes around these monsters.
>
> So I started looking at spell_util.c, since this seemed like a good place
> to start. I diffed the new and the old spell_util.c, and found there aren't
> very many places that were different, cone movement seemed the most
> appropiate change to undo.
> 
> Interesting enough, the spells now pass over the monsters as usual,
> but don't necessarily kill them. It seems the bugfix is incomplete :-(

I think this is reasonable.
All of spell cast by players have magic attacktype. 
("holyword", "banishment",.. are the exception: they don't have magic
attacktype, even if cast by players. )
Please see cast_cone() in spell_util.c.

So we cannot kill them by "face to death" since jessies and wizards
have magic immunity. 
But you may kill them by "holyword" or "banishment"..

I disagree with your patch for ok_to_put_more().
The variable "op" in ok_to_put_more() means spell object.
The variable "head" means arbitrary object at certain point in a map.
Checking liveness of spell object makes no sense.
I guess that even if you replace "head" to "op", you cannot kill
jessies by "face to death".

If you are interested in my patches, I recomment you to visit Florian
Beck's page where you can find a lot of patches for crossfire, 

URL http://www.fak14.uni-muenchen.de/~h729ihqu/games/crossfire-engl.html

and check linkes
	"Repairs relation of magic cones and immune monsters"
	"Makes magic ears always invisible".

----------
--------------------------------------------------------------------------
Seikoh Nishita		      |	Dep't. of Information & Computer Sciences
			      |	Faculty of Engineering Science
[e-mail]		      |	Osaka University
s-nisita@ics.es.osaka-u.ac.jp |	Toyonaka, Osaka 560, Japan

[to unsubscribe etc., send mail to crossfire-request@ifi.uio.no]

---

• Next by Date: No Subject
• Next by thread: No Subject
• Index(es):
  • Date
  • Thread