Crossfire Archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

CF: fear is harmless.



Fear makes creatures move back in itself.
But now fear does not seem to work correctly.

When a creature is damaged by fear,
his "SCARED" flag is set, and this flag makes him move back.
But before working , this flag is cleared! 
According to a comment in the source code(server/attack.c)
the flag is cleared because the monster won't hit back..
I think hitback process should be done before fear works
instead of clearing flag.
So, I am not satisfied with the following patch.

*** server/attack.c	Sat Mar 14 03:23:03 1998
--- server/attack.c.orig	Sun Feb  8 14:26:18 1998
***************
*** 728,734 ****
  	    maxdam=(maxdam>ndam)?maxdam:ndam;
  	}
      }
!     CLEAR_FLAG(op,FLAG_SCARED); /* Or the monster won't hit back */
      if(get_owner(hitter))
  	op->enemy=hitter->owner;
      else if (QUERY_FLAG(hitter,FLAG_ALIVE))
--- 728,738 ----
  	    maxdam=(maxdam>ndam)?maxdam:ndam;
  	}
      }
!     /* I don't know what this means. ?_? 
!      * if scared flag is clear, fear attack makes no sense.. s-nisita */
!     /*CLEAR_FLAG(op,FLAG_SCARED);  Or the monster won't hit back */
!     if (QUERY_FLAG(op,FLAG_HITBACK))
!         CLEAR_FLAG(op,FLAG_SCARED);
      if(get_owner(hitter))
  	op->enemy=hitter->owner;
      else if (QUERY_FLAG(hitter,FLAG_ALIVE))

---
--------------------------------------------------------------------------
Seikoh Nishita		      |	Dep't. of Information & Computer Sciences
			      |	Faculty of Engineering Science
[e-mail]		      |	Osaka University
s-nisita@ics.es.osaka-u.ac.jp |	Toyonaka, Osaka 560, Japan
[to unsubscribe etc., send mail to crossfire-request@ifi.uio.no]